search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
570 stars 253 forks source link

🌱 Do not mark hardwareProfile as required in the status #1819

Closed dtantsur closed 2 months ago

dtantsur commented 3 months ago

It does not change anything for v1alpha1 (it is always populated) but may send a wrong message about the field we're going to deprecate.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

elfosardo commented 2 months ago

/lgtm

kashifest commented 2 months ago

/approve

metal3-io-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment