search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
587 stars 254 forks source link

Bump CAPI to 1.8.x #1964

Closed tuminoid closed 1 month ago

tuminoid commented 1 month ago

Bump CAPI dependency to 1.8.x.

CAPI bumps brings alone CR 0.18.x and k8s.io/* v0.30.x, and it needs some migration steps.

INFO [runner] linters took 18.924923958s with stages: goanalysis_metalinter: 18.844396632s 
createVM/main.go:12:9: could not import github.com/metal3-io/baremetal-operator/test/e2e (-: # github.com/metal3-io/baremetal-operator/test/e2e
e2e/cert_manager.go:34:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)
e2e/common.go:348:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)) (typecheck)
    bmoe2e "github.com/metal3-io/baremetal-operator/test/e2e"
           ^
e2e/bmc.go:1: : # github.com/metal3-io/baremetal-operator/test/e2e [github.com/metal3-io/baremetal-operator/test/e2e.test]
e2e/cert_manager.go:34:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)
e2e/common.go:348:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply) (typecheck)

Also running osv-scanner vs bumped packages has:

ailed to run code analysis (govulncheck) on '/home/tumi/git/metal3-io/baremetal-operator/test/go.mod' because govulncheck: loading packages: 
There are errors with the provided package patterns:

/home/tumi/git/metal3-io/baremetal-operator/test/e2e/cert_manager.go:34:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)
/home/tumi/git/metal3-io/baremetal-operator/test/e2e/common.go:348:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:38:60: undefined: libvirt.StoragePool
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:40:23: undefined: libvirt.NewConnect
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:102:23: undefined: libvirt.NewConnect
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:166:23: undefined: libvirt.NewConnect
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:211:23: undefined: libvirt.NewConnect
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:249:11: undefined: libvirt.NETWORK_UPDATE_COMMAND_ADD_LAST
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:250:11: undefined: libvirt.NETWORK_SECTION_IP_DHCP_HOST
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:253:11: undefined: libvirt.NETWORK_UPDATE_AFFECT_LIVE
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:253:46: undefined: libvirt.NETWORK_UPDATE_AFFECT_CONFIG
tuminoid commented 1 month ago

Dependabot has example bumps, which cannot merge and should autoclose with a proper fix PR.

kashifest commented 1 month ago

/assign @kashifest /triage accepted