search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
592 stars 253 forks source link

✨ Allow FirmwareUpdates via Servicing with HostUpdatePolicy #2044

Closed iurygregory closed 1 week ago

iurygregory commented 2 weeks ago

What this PR does / why we need it: This a follow-up to add support for Firmware Updates via HostUpdatePolicy, finalizing the implementation of metal3-io/metal3-docs@e260d42

iurygregory commented 2 weeks ago

/hold we need to wait for #2041 so I can rebase this one.

iurygregory commented 2 weeks ago

/unhold

iurygregory commented 2 weeks ago

/hold cancel

iurygregory commented 2 weeks ago

/ok-to-test

rhjanders commented 2 weeks ago

Thank you Iury. It passes CI and addresses in-code TODOs so /lgtm (let me try if I have reviewer rights upstream). If this works it would be get another pair of eyes on it, too, since I am still very new to this codebase.

metal3-io-bot commented 2 weeks ago

@rhjanders: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/baremetal-operator/pull/2044#issuecomment-2467087674): >Thank you Iury. It passes CI and addresses in-code TODOs so >/lgtm >(let me try if I have reviewer rights upstream). >If this works it would be get another pair of eyes on it, too, since I am still very new to this codebase. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rhjanders commented 2 weeks ago

@rhjanders: adding LGTM is restricted to approvers and reviewers in OWNERS files.

well, clearly I do not :)

tuminoid commented 2 weeks ago

/cc @lentzi90 @dtantsur

elfosardo commented 2 weeks ago

/lgtm

dtantsur commented 2 weeks ago

/cc @zaneb

honza commented 2 weeks ago

/lgtm

iurygregory commented 1 week ago

e2e-test (ipmi) Error: No files were found with the provided path: test/e2e/_artifacts. No artifacts will be uploaded. 🤔

metal3-io-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 1 week ago

/lgtm