search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
592 stars 253 forks source link

🐛 Fix the logic that determines previous git tag #2045

Closed huutomerkki closed 2 weeks ago

huutomerkki commented 3 weeks ago

What this PR does / why we need it:

This PR changes the way previous tag is determined to only include those tags that have been merged into the current tree.

metal3-io-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 3 weeks ago

Also, https://github.com/metal3-io/ip-address-manager/pull/734 in IPAM will change the release creation logic, and will implement the same in Go code, so it makes no sense to implement this here.