🌱 Adjust test and linter timings

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes

Apache License 2.0

592 stars 253 forks source link

🌱 Adjust test and linter timings #2046

Closed lentzi90 closed 2 weeks ago

lentzi90 commented 2 weeks ago

What this PR does / why we need it:

We have started hitting the deadline for golangci-lint. This commit doubles it from 5m to 10m. It also adjusts the fixture provisioners artificial inspection delay and the interval that is used when checking for it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

lentzi90 commented 2 weeks ago

/test test

lentzi90 commented 2 weeks ago

The test test passed. This was the one that hit golangci-lint timeout before.
The fixture test passed inspection. However, it failed in the cleanup. I believe it is this known flake. I will try retriggering.

/retest

metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [Rozzii] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

Rozzii commented 2 weeks ago

/retest

lentzi90 commented 2 weeks ago

Hmm the second run also failed in the same way:

   [FAILED] in [AfterEach] - /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/common.go:130 @ 11/08/24 08:03:41.774
• [FAILED] [64.322 seconds]
Re-Inspection [AfterEach] should re-inspect the annotated BMH [required, re-inspection]
  [AfterEach] /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/re_inspection_test.go:108
  [It] /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/re_inspection_test.go:39

  [FAILED] Timed out after 60.000s.
  Expected
      <bool>: false
  to be true
  In [AfterEach] at: /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/common.go:130

lentzi90 commented 2 weeks ago

That is where it is waiting for the namespace to be deleted. I will look into this a bit more. Perhaps there are more deadlines that should be adjusted.