search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
592 stars 253 forks source link

:bug: Make custom deploy equivalent to image deploy #2048

Closed zaneb closed 6 days ago

zaneb commented 2 weeks ago

If we have to recreate the provisioner's state during deprovisioning, we must first call Adopt() to ensure that something will actually happen to deprovision it. This is the case regardless of provisioning method, but previously only happened when an image was provisioned. In practice, the ironic provisioner was attempting to adopt in cases where it was not originally intended to, and subsequent changes mean it is never necessary.

If an externally provisioned host has a provisioning image set and then the externallyProvisioned flag is removed, we should not begin an inspection (which would involve rebooting the host), but instead move directly to the provisioned state. This is also the case regardless of provisioning method, but previously only happened when an image was provisioned.

zaneb commented 2 weeks ago

/cc @dtantsur

zaneb commented 2 weeks ago

/hold cancel

tuminoid commented 2 weeks ago

/retest

tuminoid commented 2 weeks ago

It seems Prow is having issues. Failures are non PR related.

dtantsur commented 2 weeks ago

/approve

Looks valid to me.

metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dtantsur commented 2 weeks ago

/test generate /test gomod /test manifestlint

kashifest commented 1 week ago

/test ?

metal3-io-bot commented 1 week ago

@kashifest: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/baremetal-operator/pull/2048#issuecomment-2482646520): >/test ? > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kashifest commented 6 days ago

/test metal3-e2e-clusterctl-upgrade-test-main

kashifest commented 6 days ago

/lgtm