search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
592 stars 253 forks source link

🐛 Update HFC Status when handling error in actionPreparing #2060

Closed iurygregory closed 4 days ago

iurygregory commented 1 week ago

When a provisioning error happens and firmware updates are involved, we should only set the Status Updates of the HFC to nil if they are not nil.

s3rj1k commented 1 week ago

/ok-to-test

tuminoid commented 1 week ago

/ok-to-test

Btw, ok-to-test is not needed for Metal3 members.

zaneb commented 1 week ago

/approve

metal3-io-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [zaneb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dtantsur commented 4 days ago

/lgtm