search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
592 stars 253 forks source link

:seedling: use uuidgen to generate random username/password #2063

Closed tuminoid closed 1 week ago

tuminoid commented 1 week ago

Using /dev/urandom has entropy issue. It can run out especially in CI, leaving jobs stuck. We have used uuidgen in BMO e2e for long time now and it works great. These usernames/passwords just need to be anything random to make sure nothing is hardcoded, so uuidgen works great for that anyways.

tuminoid commented 1 week ago

/cc @lentzi90

metal3-io-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kashifest commented 1 week ago

/lgtm

tuminoid commented 1 week ago

/cherry-pick release-0.8

tuminoid commented 1 week ago

/cherry-pick release-0.6

metal3-io-bot commented 1 week ago

@tuminoid: new pull request created: #2067

In response to [this](https://github.com/metal3-io/baremetal-operator/pull/2063#issuecomment-2487787133): >/cherry-pick release-0.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 1 week ago

@tuminoid: new pull request created: #2068

In response to [this](https://github.com/metal3-io/baremetal-operator/pull/2063#issuecomment-2487787664): >/cherry-pick release-0.6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.