search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
592 stars 253 forks source link

🌱 Do not add colons to structured logging #2084

Open dtantsur opened 4 days ago

dtantsur commented 4 days ago

It does not work by concatenating strings.

This reverts commit 3a4cabbe135b6f392085ec6272f42ab4b6cefa14.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

metal3-io-bot commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tuminoid Once this PR has been reviewed and has the lgtm label, please ask for approval from dtantsur. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 4 days ago

/lgtm

tuminoid commented 3 days ago

/cc @kashifest