search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
208 stars 91 forks source link

🌱 refactor TLS config #1724

Closed tuminoid closed 4 months ago

tuminoid commented 4 months ago

TLS config code causes security linters to report false positive about TLS versions that can be configured.

This is porting over CAPO PR 2037.

tuminoid commented 4 months ago

/test metal3-ubuntu-e2e-integration-test-main

tuminoid commented 4 months ago

/test metal3-ubuntu-e2e-integration-test-main

tuminoid commented 4 months ago

/override metal3-centos-e2e-integration-test-main Centos is unstable, Ubuntu + unit passed.

/cc @mboukhalfa @lentzi90

metal3-io-bot commented 4 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1724#issuecomment-2120010538): >/override metal3-centos-e2e-integration-test-main >Centos is unstable, Ubuntu + unit passed. > >/cc @mboukhalfa @lentzi90 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Rozzii commented 4 months ago

/lgtm

metal3-io-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment