metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
208 stars 91 forks source link

Add OutOfServiceTaint to Node Instead of Deleting Node Object #1725

Closed clobrano closed 2 months ago

clobrano commented 4 months ago

User Story

As an operator, I would like to add an OutOfServiceTaint to a Node instead of deleting the Node object.

Detailed Description

For Kubernetes >= 1.28 Add the out-of-service taint in place of deleting the Node object Kubernetes >= 1.28

For Kubernetes < 1.28 Keep the current behavior

Anything else you would like to add:

/kind feature

clobrano commented 4 months ago

I introduced this request on slack and I'd like to implement it

Rozzii commented 3 months ago

Previous proposal: https://github.com/metal3-io/cluster-api-provider-metal3/pull/367 K8s feature related info: https://kubernetes.io/blog/2023/08/16/kubernetes-1-28-non-graceful-node-shutdown-ga/ I am okay with this: /triage accepted

clobrano commented 3 months ago

Great, working on it

clobrano commented 3 months ago

/assign

clobrano commented 3 months ago

/lifecycle active