search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

🌱 Minor cleaning of M3DT manager code #1730

Closed lentzi90 closed 1 month ago

lentzi90 commented 1 month ago

What this PR does / why we need it:

This improves naming, adds comments, etc. No functional changes!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

lentzi90 commented 1 month ago

/test metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [Sunnatillo,kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Sunnatillo commented 1 month ago

/lgtm

lentzi90 commented 1 month ago

/test metal3-ubuntu-e2e-integration-test-main

lentzi90 commented 1 month ago

/override metal3-centos-e2e-integration-test-main This test is broken at the moment and this PR does not make any functional changes anyway.

metal3-io-bot commented 1 month ago

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-centos-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1730#issuecomment-2126736689): >/override metal3-centos-e2e-integration-test-main >This test is broken at the moment and this PR does not make any functional changes anyway. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.