search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

🌱 Allow minor version bumps for golang.org/x/* dependancies for release branch #1732

Closed kashifest closed 1 month ago

kashifest commented 1 month ago

golang.org/x/* libs only release minor versions. No patch versions. We need to allow minor version bumps for these libs for release branches for this reason.

kashifest commented 1 month ago

/cc @tuminoid

tuminoid commented 1 month ago

Did you find any documentation that which order the config applies, ie. should the x/net be first or last to override the * ? If you did, can you link it here for reference?

kashifest commented 1 month ago

Did you find any documentation that which order the config applies, ie. should the x/net be first or last to override the * ? If you did, can you link it here for reference?

I didnt unfortunately. I am relying on the fact that the ipam ignore is working even though we have an * rule.

tuminoid commented 1 month ago

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 1 month ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1732#issuecomment-2128628621): >/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [tuminoid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment