search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

🌱 Move golang.org/x/* ignore rules after the * rule #1745

Closed kashifest closed 1 month ago

kashifest commented 1 month ago

Dependabot is not picking up the ignore rule for golang.org/x/* and hence not updating it. It might be the * is superseding everything. We will try to move it below the * rule to check if it helps dependabot picking it up Signed-off-by: Kashif Khan kashif.khan@est.tech

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

kashifest commented 1 month ago

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 1 month ago

@kashifest: Overrode contexts on behalf of kashifest: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1745#issuecomment-2134558155): >/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kashifest commented 1 month ago

/assign @tuminoid

tuminoid commented 1 month ago

/retitle 🌱 Move golang.org/x/ ignore rules after the rule

Removed the formatting, as it'll look funny in the release notes.

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [tuminoid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kashifest commented 1 month ago

/cc @lentzi90 @Sunnatillo @smoshiur1237