search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
208 stars 90 forks source link

:warning: Fix enableBMHNameBasedPreallocation label to ENABLE_BMH_NAME_BASED_PR… #1751

Closed peppi-lotta closed 2 months ago

peppi-lotta commented 3 months ago

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #https://github.com/metal3-io/cluster-api-provider-metal3/issues/1242

peppi-lotta commented 3 months ago

/test metal3-ubuntu-e2e-integration-test-main /test metal3-centos-e2e-integration-test-main

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [smoshiur1237] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kashifest commented 3 months ago

/hold For the change requested and feature test to pass

peppi-lotta commented 3 months ago

/test metal3-ubuntu-e2e-feature-test-main /test metal3-centos-e2e-feature-test-main

kashifest commented 3 months ago

/test metal3-ubuntu-e2e-feature-test-main

kashifest commented 3 months ago

/test metal3-centos-e2e-feature-test-main

kashifest commented 3 months ago

/test metal3-centos-e2e-feature-test-main

kashifest commented 3 months ago

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

tuminoid commented 3 months ago

/hold For the change requested and feature test to pass

All tests are passed, shall we unhold?

Rozzii commented 2 months ago

I will check what docs will need to change to support this then we can merge.

Rozzii commented 2 months ago

@adilGhaffarDev has volunteered to create an updated version of this PR and we will try to get this merged.

adilGhaffarDev commented 2 months ago

I have rebased it, please check.

adilGhaffarDev commented 2 months ago

LGTM from my side @mboukhalfa @Rozzii please check

adilGhaffarDev commented 2 months ago

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

Rozzii commented 2 months ago

/hold cancel let's see what breaks :D