search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

:bug: Changing errors in pause annotation functions from terminal to transient #1762

Closed adilGhaffarDev closed 3 weeks ago

adilGhaffarDev commented 3 weeks ago

What this PR does / why we need it: Changing errors in pause annotation functions from terminal to transient. When BMH is rebooted there is a chance we get a terminal error from these functions which can cause machines to be in a failed state.

metal3-io-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from adilghaffardev. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/release-1.7/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
adilGhaffarDev commented 3 weeks ago

/test ?

metal3-io-bot commented 3 weeks ago

@adilGhaffarDev: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1762#issuecomment-2165092690): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
adilGhaffarDev commented 3 weeks ago

/test metal3-centos-e2e-feature-test-release-1-7

adilGhaffarDev commented 3 weeks ago

/test metal3-ubuntu-e2e-feature-test-release-1-7

adilGhaffarDev commented 3 weeks ago

/metal3-centos-e2e-integration-test-release-1-7

adilGhaffarDev commented 3 weeks ago

@mboukhalfa @kashifest please check.

metal3-io-bot commented 3 weeks ago

@adilGhaffarDev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test 2305ec6b32d6b8d649bb9a4a0e22388041e103a8 link true /test test
markdownlint 2305ec6b32d6b8d649bb9a4a0e22388041e103a8 link true /test markdownlint
shellcheck 2305ec6b32d6b8d649bb9a4a0e22388041e103a8 link true /test shellcheck
build 2305ec6b32d6b8d649bb9a4a0e22388041e103a8 link true /test build
manifestlint 2305ec6b32d6b8d649bb9a4a0e22388041e103a8 link true /test manifestlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mboukhalfa commented 3 weeks ago

/close surpassed by https://github.com/metal3-io/cluster-api-provider-metal3/pull/1765