search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
208 stars 90 forks source link

:bug: Changing errors in pause annotation functions from terminal to transient #1765

Closed adilGhaffarDev closed 3 months ago

adilGhaffarDev commented 3 months ago

What this PR does / why we need it: Changing errors in pause annotation functions from terminal to transient. When BMH is rebooted there is a chance we get a terminal error from these functions which can cause machines to be in a failed state.

mboukhalfa commented 3 months ago

/approve

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [mboukhalfa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mboukhalfa commented 3 months ago

/cherry-pick release-1.7

metal3-io-bot commented 3 months ago

@mboukhalfa: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1765#issuecomment-2165519636): >/cherry-pick release-1.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
adilGhaffarDev commented 3 months ago

/test metal3-ubuntu-e2e-integration-test-main

mboukhalfa commented 3 months ago

/override metal3-centos-e2e-integration-test-main

metal3-io-bot commented 3 months ago

@mboukhalfa: Overrode contexts on behalf of mboukhalfa: metal3-centos-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1765#issuecomment-2165939667): >/override metal3-centos-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 3 months ago

@mboukhalfa: new pull request created: #1766

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1765#issuecomment-2165519636): >/cherry-pick release-1.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.