search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

📖 overridable variables in the clusterctl-cluster.yaml template #1771

Closed tannerjones4075 closed 1 week ago

tannerjones4075 commented 2 weeks ago

What this PR does / why we need it: The PR adds variables to override the default cidrblocks for the services and pods in the clusterctl-cluster.yaml template file. Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # fixes #1484

metal3-io-bot commented 2 weeks ago

Hi @tannerjones4075. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mboukhalfa commented 2 weeks ago

/ok-to-test

Rozzii commented 2 weeks ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

mboukhalfa commented 1 week ago

/approve

metal3-io-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [mboukhalfa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment