metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

:seedling: Bump k8s.io/code-generator from 0.29.3 to 0.30.2 in /hack/tools #1779

Closed dependabot[bot] closed 1 week ago

dependabot[bot] commented 2 weeks ago

Bumps k8s.io/code-generator from 0.29.3 to 0.30.2.

Commits
  • c49bce7 Update dependencies to v0.30.2 tag
  • e5a48a5 Merge pull request #124371soltysh/automated-cherry-pick-of-#123893#124...
  • b23df5e Update applyconfig-gen for pacakges where group and dir differ in name
  • 64318e9 kube_codegen: expose applyconfig-openapi-schema flag for client generation
  • e1372fd Merge remote-tracking branch 'origin/master' into release-1.30
  • b8aa536 Update x/net for CVE-2023-45288
  • 7142117 Merge pull request #123735 from thockin/master
  • c9df80e Merge pull request #123758 from liggitt/protobump
  • 5b26ad6 Bump github.com/golang/protobuf v1.5.4, google.golang.org/protobuf v1.33.0
  • bfe3706 Don't embed plural exceptions in tools
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign adilghaffardev for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 2 weeks ago

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 weeks ago

/hold Done in https://github.com/metal3-io/cluster-api-provider-metal3/pull/1769

kashifest commented 2 weeks ago

This will superceed https://github.com/metal3-io/cluster-api-provider-metal3/pull/1769 actually , its bumping the toolchain to 1.22.4, #1769 yours 1.22.3, do we explicitly want it to be 1.22.3 ?

tuminoid commented 2 weeks ago

This will superceed #1769 actually , its bumping the toolchain to 1.22.4, #1769 yours 1.22.3, do we explicitly want it to be 1.22.3 ?

We don't want toolchain to be in go.mod, and 1.22.3 satisfies the dependency's need. Keeping it at a mininum to allow developer's some flexibility in their Go version (similar to having go 1.22, which just isn't possible here)

kashifest commented 2 weeks ago

We don't want toolchain to be in go.mod

But we have to live with it now no?

kashifest commented 2 weeks ago

We don't want toolchain to be in go.mod, and 1.22.3 satisfies the dependency's need. Keeping it at a mininum to allow developer's some flexibility in their Go version (similar to having go 1.22, which just isn't possible here)

ok, got the point

tuminoid commented 2 weeks ago

We don't want toolchain to be in go.mod

But we have to live with it now no?

If our go directive fulfills the dependency's need, then we don't need it. As you can see in my manual PR #1769

kashifest commented 2 weeks ago

if theres a CVE for 1.22.3 we cant keep it bare minimum. Personally, I dont like this way of working, and for development branch, I feel we should use the latest patch, but as others have different opinions, I am ok to keep it minimum

tuminoid commented 2 weeks ago

if theres a CVE for 1.22.3 we cant keep it bare minimum. Personally, I dont like this way of working, and for development branch, I feel we should use the latest patch, but as others have different opinions, I am ok to keep it minimum

CVE fixes to Goland is coming from Dockerifle Golang image version, which is 1.22.4. We have always kept directive without patch go 1.22 which is equivalent to go 1.22.0. go.mod only dictates the minimum version local Golang must be, thus directly affecting both developers and consumers, but not the container image / deliverable security.

dependabot[bot] commented 1 week ago

Looks like k8s.io/code-generator is up-to-date now, so this is no longer needed.