Closed dependabot[bot] closed 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign adilghaffardev for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @dependabot[bot]. Thanks for your PR.
I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
This will superceed https://github.com/metal3-io/cluster-api-provider-metal3/pull/1769 actually , its bumping the toolchain to 1.22.4, #1769 yours 1.22.3, do we explicitly want it to be 1.22.3 ?
This will superceed #1769 actually , its bumping the toolchain to 1.22.4, #1769 yours 1.22.3, do we explicitly want it to be 1.22.3 ?
We don't want toolchain to be in go.mod, and 1.22.3 satisfies the dependency's need. Keeping it at a mininum to allow developer's some flexibility in their Go version (similar to having go 1.22
, which just isn't possible here)
We don't want toolchain to be in go.mod
But we have to live with it now no?
We don't want toolchain to be in go.mod, and 1.22.3 satisfies the dependency's need. Keeping it at a mininum to allow developer's some flexibility in their Go version (similar to having
go 1.22
, which just isn't possible here)
ok, got the point
We don't want toolchain to be in go.mod
But we have to live with it now no?
If our go
directive fulfills the dependency's need, then we don't need it. As you can see in my manual PR #1769
if theres a CVE for 1.22.3 we cant keep it bare minimum. Personally, I dont like this way of working, and for development branch, I feel we should use the latest patch, but as others have different opinions, I am ok to keep it minimum
if theres a CVE for 1.22.3 we cant keep it bare minimum. Personally, I dont like this way of working, and for development branch, I feel we should use the latest patch, but as others have different opinions, I am ok to keep it minimum
CVE fixes to Goland is coming from Dockerifle Golang image version, which is 1.22.4
. We have always kept directive without patch go 1.22
which is equivalent to go 1.22.0
. go.mod
only dictates the minimum version local Golang must be, thus directly affecting both developers and consumers, but not the container image / deliverable security.
Looks like k8s.io/code-generator is up-to-date now, so this is no longer needed.
Bumps k8s.io/code-generator from 0.29.3 to 0.30.2.
Commits
c49bce7
Update dependencies to v0.30.2 tage5a48a5
Merge pull request #124371soltysh/automated-cherry-pick-of-#123893
#124...b23df5e
Update applyconfig-gen for pacakges where group and dir differ in name64318e9
kube_codegen: expose applyconfig-openapi-schema flag for client generatione1372fd
Merge remote-tracking branch 'origin/master' into release-1.30b8aa536
Update x/net for CVE-2023-452887142117
Merge pull request #123735 from thockin/masterc9df80e
Merge pull request #123758 from liggitt/protobump5b26ad6
Bump github.com/golang/protobuf v1.5.4, google.golang.org/protobuf v1.33.0bfe3706
Don't embed plural exceptions in toolsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show