search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

:seedling: Bump github.com/docker/docker from 26.1.4+incompatible to 27.0.0+incompatible in /test #1780

Open dependabot[bot] opened 2 weeks ago

dependabot[bot] commented 2 weeks ago

Bumps github.com/docker/docker from 26.1.4+incompatible to 27.0.0+incompatible.

Release notes

Sourced from github.com/docker/docker's releases.

v27.0.0-rc.2

27.0.0-rc.2

For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones:

New

  • In port mappings with no host port specified, and with host port ranges, allocate the same port for IPv4 and IPv6. Add bridge driver option com.docker.network.bridge.gateway_mode_ipv6=<nat|routed>, when set to routed no NAT or masquerading rules are configured for port mappings. This enables direct IPv6 access to the container, if the host's network can route packets for the container's address to the host. Mapped ports will be opened in the containers firewall. For example, docker network create --ipv6 -o com.docker.network.bridge.gateway_mode_ipv6=routed mynet. Option com.docker.network.bridge.gateway_mode_ipv4=<nat|routed> is also available. moby/moby#47871

Bug fixes and enhancements

  • Fix a goroutine and file-descriptor leak on container attach. moby/moby#45052
  • Clear the networking state of all stopped or dead containers during daemon start-up. moby/moby#47984
  • Environment variable DOCKER_ALLOW_IPV6_ON_IPV4_INTERFACE, introduced in release 26.1.1, no longer has any effect. If IPv6 could not be disabled on an interface because of a read-only /proc/sys/net, the environment variable allowed the container to start anyway. IPv6 can now be explicitly enabled simply by using --ipv6 when creating the network, it is no longer necessary to allocate a subnet as a unique-local prefix will be selected by default. Other workarounds are to configure the OS to disable IPv6 by default on new interfaces, mount /proc/sys/net read-write, or use a kernel with no IPv6 support. moby/moby#47963

Removed

  • pkg/archive: deprecate NewTempArchive, TempArchive. These types were only used in tests and will be removed in the next release. moby/moby#48002
  • pkg/archive: deprecate CanonicalTarNameForPath moby/moby#48001
  • Deprecate pkg/dmesg. This package was no longer used, and will be removed in the next release. moby/moby#47999
  • Deprecate pkg/stringid.ValidateID and pkg/stringid.IsShortID moby/moby#47995
  • runconfig: deprecate SetDefaultNetModeIfBlank and move ContainerConfigWrapper to api/types/container moby/moby#48007

API

  • POST /containers/create and POST /services/create now take Options as part of HostConfig.Mounts.TmpfsOptions allowing to set options for tmpfs mounts. moby/moby#46809
  • The Healthcheck.StartInterval property is now correctly ignored when updating a Swarm service using API versions less than v1.44. moby/moby#47991
  • GET /events now supports image create event that is emitted when a new image is built regardless if it was tagged or not. moby/moby#47929
  • GET /info now includes a Containerd field containing information about the location of the containerd API socket and containerd namespaces used by the daemon to run containers and plugins. moby/moby#47239

Packaging updates

v27.0.0-rc.1

27.0.0-rc.1

For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones:

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign adilghaffardev for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 2 weeks ago

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 weeks ago

/ok-to-test /retest

tuminoid commented 2 weeks ago

Hmm, whats up with golangci-lint? Does not look like Docker bump issue... @kashifest

https://github.com/metal3-io/cluster-api-provider-metal3/actions/runs/9554048035/job/26349548409?pr=1780

run golangci-lint
  Running [/home/runner/golangci-lint-1.56.2-linux-amd64/golangci-lint run --path-prefix=test] in [/home/runner/work/cluster-api-provider-metal3/cluster-api-provider-metal3/test] ...
  Received 1288363 of 1288363 (100.0%), 1.2 MBs/sec
  level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package container: could not load export data: no export data for \"sigs.k8s.io/cluster-api/test/infrastructure/container\""
  level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package container: could not load export data: no export data for \"sigs.k8s.io/cluster-api/test/infrastructure/container\""
tuminoid commented 2 weeks ago

/retest

Hmm, whats up with golangci-lint? Does not look like Docker bump issue... @kashifest

https://github.com/metal3-io/cluster-api-provider-metal3/actions/runs/9554048035/job/26349548409?pr=1780

run golangci-lint
  Running [/home/runner/golangci-lint-1.56.2-linux-amd64/golangci-lint run --path-prefix=test] in [/home/runner/work/cluster-api-provider-metal3/cluster-api-provider-metal3/test] ...
  Received 1288363 of 1288363 (100.0%), 1.2 MBs/sec
  level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package container: could not load export data: no export data for \"sigs.k8s.io/cluster-api/test/infrastructure/container\""
  level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package container: could not load export data: no export data for \"sigs.k8s.io/cluster-api/test/infrastructure/container\""

OK, build fails as well. There is incompatibility with CAPI 1.7.3 here, hence failing.

# sigs.k8s.io/cluster-api/test/infrastructure/container
/home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.7.3/infrastructure/container/docker.go:121:62: undefined: types.ImagePullOptions
/home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.7.3/infrastructure/container/docker.go:140:53: undefined: types.ImageListOptions

/hold Needs CAPI 1.8

tuminoid commented 2 weeks ago

/retest

metal3-io-bot commented 2 weeks ago

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build 356ef22802c81dd51b9787243d40eaca9c0789e2 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kashifest commented 1 week ago

This version of docker client had issues while releasing in upstream, check this comment, I noticed it yesterday and pushed a bump in CAPI upstream, https://github.com/kubernetes-sigs/cluster-api/pull/10794, dependabot should pick it up soon, or then I will bump it as part of #1805