metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

:seedling: Bump sigs.k8s.io/controller-runtime from 0.16.5 to 0.16.6 in /test #1799

Open dependabot[bot] opened 2 weeks ago

dependabot[bot] commented 2 weeks ago

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps sigs.k8s.io/controller-runtime from 0.16.5 to 0.16.6.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.16.6

What's Changed

Full Changelog: https://github.com/kubernetes-sigs/controller-runtime/compare/v0.16.5...v0.16.6

Commits
  • cc6cba0 Merge pull request #2816 from k8s-infra-cherrypick-robot/cherry-pick-2813-to-...
  • 0bb3250 Reintroduce AddMetricsExtraHandler on manager
  • 24c2359 Merge pull request #2814 from vincepri/k8s-1289
  • 4964929 [release-0.16] Update to Kubernetes v0.28.9
  • 38e7e99 Merge pull request #2775 from k8s-infra-cherrypick-robot/cherry-pick-2771-to-...
  • c9bfc87 ✨ client: Add client-wide fieldManager
  • See full diff in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign adilghaffardev for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/release-1.6/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 2 weeks ago

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kashifest commented 2 weeks ago

/hold

kashifest commented 2 weeks ago

@dependabot recreate

kashifest commented 2 weeks ago

title says its bumping to v0.16.6 but why on earth in the code its bumping to v0.17.x

kashifest commented 2 weeks ago

@dependabot show sigs.k8s.io/controller-runtime ignore conditions

dependabot[bot] commented 2 weeks ago

No ignore conditions found for the dependency sigs.k8s.io/controller-runtime

kashifest commented 2 weeks ago

Issue opened in depedabot https://github.com/dependabot/dependabot-core/issues/10037 lets see

metal3-io-bot commented 1 week ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Rozzii commented 4 days ago

I won't add a milestone to this because this might not even get merged .