search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

🌱Add namespace directory in manifest collection #1800

Closed smoshiur1237 closed 1 week ago

smoshiur1237 commented 1 week ago

There is a possibility to miss same kinds of manifest in different namespace. So this PR will add the namespace directory in manifest collection to gather all the manifests which will improve debugging capability.

smoshiur1237 commented 1 week ago

/test metal3-ubuntu-e2e-integration-test-main

smoshiur1237 commented 1 week ago

One test would be enough to check the added directory, so overriding the 2nd test. /override metal3-centos-e2e-integration-test-main

metal3-io-bot commented 1 week ago

@smoshiur1237: Overrode contexts on behalf of smoshiur1237: metal3-centos-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1800#issuecomment-2178155630): >One test would be enough to check the added directory, so overriding the 2nd test. >/override metal3-centos-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
smoshiur1237 commented 1 week ago

/cc @tuminoid @mboukhalfa

smoshiur1237 commented 1 week ago

Manifest collection is done under different namespace directory: https://jenkins.nordix.org/view/Metal3/job/metal3-ubuntu-e2e-integration-test-main/310/

metal3-io-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [mboukhalfa,tuminoid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Rozzii commented 1 week ago

@smoshiur1237 Is it intentional that these new directories are empty? image /hold Just holding until I get answer

Rozzii commented 1 week ago

Okay, i have got my answer offline, probably in the future we should improve on this in terms of not creating all the "kind" directories for all the namespaces because many of them will be just empty dirs but this PR is a step in the right direction. /hold cancel /lgtm