search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
194 stars 87 forks source link

🌱 Fix issues in running local hack scripts #1810

Closed tuminoid closed 4 days ago

tuminoid commented 4 days ago

In CAPM3, there was only issues in codegen. Fix that, plus made it dynamically detect all the config and generated files, so they're included if they'd be generated elsewhere. It is in line with BMO generate.sh now.

For others, simply adding one shellcheck ignore for a optional check many people have enabled about, tired of seeing my editor complain :)

tuminoid commented 4 days ago

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 4 days ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1810#issuecomment-2196554702): >/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 4 days ago

/cc @kashifest @Rozzii

kashifest commented 4 days ago

/approve

metal3-io-bot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment