search

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
208 stars 91 forks source link

:seedling: remove KUBECTL_SHA256 passthru #1822

Closed tuminoid closed 3 months ago

tuminoid commented 3 months ago

We no longer need to pass-thru KUBECTL_SHA256 as we download it and verify it from the downloaded checksum.

This depends on https://github.com/metal3-io/metal3-dev-env/pull/1437 merging first. /hold

tuminoid commented 3 months ago

OK, dev-env fix is in, let's see if we can merge this.

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

tuminoid commented 3 months ago

/cc @kashifest @Rozzii /retitle remove KUBECTL_SHA256 passthru /unhold

Good to merge.

tuminoid commented 3 months ago

/retitle :seedling: remove KUBECTL_SHA256 passthru

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
adilGhaffarDev commented 3 months ago

/lgtm

tuminoid commented 3 months ago

/cherry-pick release-1.7

metal3-io-bot commented 3 months ago

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1822#issuecomment-2202636034): >/cherry-pick release-1.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 3 months ago

@tuminoid: #1822 failed to apply on top of branch "release-1.7":

Applying: remove KUBECTL_SHA256 passthru
Using index info to reconstruct a base tree...
M   scripts/ci-e2e.sh
M   scripts/environment.sh
Falling back to patching base and 3-way merge...
Auto-merging scripts/environment.sh
CONFLICT (content): Merge conflict in scripts/environment.sh
Auto-merging scripts/ci-e2e.sh
CONFLICT (content): Merge conflict in scripts/ci-e2e.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 remove KUBECTL_SHA256 passthru
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1822#issuecomment-2202636034): >/cherry-pick release-1.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.