metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api
Apache License 2.0
212 stars 96 forks source link

🌱 Use wget while downloading image #2110

Closed kashifest closed 1 day ago

kashifest commented 1 day ago

Recently we have experienced net.OpError error or http2streamerror error while downloading image quite frequently. This PR uses wget instead which is more resilient to http/network issues. We should change it to httpGet when network improves again.

kashifest commented 1 day ago

/test metal3-centos-e2e-feature-test-main-pivoting

adilGhaffarDev commented 1 day ago

/test ?

metal3-io-bot commented 1 day ago

@adilGhaffarDev: The following commands are available to trigger required jobs:

/test build
/test generate
/test gomod
/test manifestlint
/test markdownlint
/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main
/test shellcheck
/test test
/test unit

The following commands are available to trigger optional jobs:

/test metal3-centos-e2e-basic-test-main
/test metal3-centos-e2e-feature-test-main-features
/test metal3-centos-e2e-feature-test-main-pivoting
/test metal3-centos-e2e-feature-test-main-remediation
/test metal3-e2e-1-29-1-30-upgrade-test-main
/test metal3-e2e-clusterctl-upgrade-test-main
/test metal3-ubuntu-e2e-basic-test-main
/test metal3-ubuntu-e2e-feature-test-main-features
/test metal3-ubuntu-e2e-feature-test-main-pivoting
/test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

build
generate
gomod
manifestlint
unit
In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/2110#issuecomment-2500392150): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
adilGhaffarDev commented 1 day ago

/test metal3-centos-e2e-feature-test-main-features

kashifest commented 1 day ago

/test metal3-centos-e2e-feature-test-main-features

/test metal3-centos-e2e-feature-test-main-pivoting

kashifest commented 1 day ago

/test metal3-centos-e2e-feature-test-main-features

/test metal3-centos-e2e-feature-test-main-pivoting

tuminoid commented 1 day ago

Recently we have experienced net.OpError error or http2streamerror error while downloading image quite frequently. This PR uses wget instead which is more resilient to http/network issues. We should change it to httpGet when network improves again.

Just noting that implementing Go with HTTP/1 might be worth a try. Wget on Ubuntu is still not built with HTTP/2 by default, so it might be more robust choice for Go client as well. Go by default is using HTTP/2 and as you wrote on the summary, seems to be source of the issues.

kashifest commented 1 day ago

Just noting that implementing Go with HTTP/1 might be worth a try. Wget on Ubuntu is still not built with HTTP/2 by default, so it might be more robust choice for Go client as well. Go by default is using HTTP/2 and as you wrote on the summary, seems to be source of the issues.

Yep for now, lets take the CI back, I will do a followup soon

adilGhaffarDev commented 1 day ago

/approve

metal3-io-bot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [adilGhaffarDev] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kashifest commented 1 day ago

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

kashifest commented 1 day ago

/test metal3-ubuntu-e2e-integration-test-main