search

metal3-io / ip-address-manager

IP address Manager for Cluster API Provider Metal3
Apache License 2.0
48 stars 31 forks source link

Remove gofmt make targets and script #466

Closed lentzi90 closed 5 months ago

lentzi90 commented 6 months ago

We use golangci-lint that includes gosec, gofmt and govet already. These redundant checks should be removed. Remove them from the Makefile and remove the redundant scripts in hack.

lentzi90 commented 6 months ago

/good-first-issue /triage accepted

metal3-io-bot commented 6 months ago

@lentzi90: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/metal3-io/ip-address-manager/issues/466): >/good-first-issue >/triage accepted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tico88612 commented 5 months ago

/assign