search

metal3-io / ip-address-manager

IP address Manager for Cluster API Provider Metal3
Apache License 2.0
51 stars 33 forks source link

🌱 Increase time for golint test to avoid timeout failure #745

Closed smoshiur1237 closed 4 days ago

smoshiur1237 commented 4 days ago

We have seen failure in golint test failure because of time out. Sometimes it takes more than 5 minutes to finish the job. So increasing the test timeout should fix this failure.

smoshiur1237 commented 4 days ago

/cc @Sunnatillo @tuminoid Please also override the CI test.

metal3-io-bot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ip-address-manager/blob/main/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lentzi90 commented 4 days ago

/override metal3-centos-e2e-integration-test-main /override metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 4 days ago

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/ip-address-manager/pull/745#issuecomment-2475677996): >/override metal3-centos-e2e-integration-test-main >/override metal3-ubuntu-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.