search

metal3-io / ironic-client

Ironic Client Utilities (for debugging via Ironic APIs)
Apache License 2.0
3 stars 10 forks source link

use image as debug container #16

Closed jklippel closed 1 month ago

jklippel commented 10 months ago

Currently the image only starts the baremetal command without any environment variables set.

This commit introduces the sourcing of the ironic.conf of a pod to which the container can be attached as debug container. The baremetal cli is then directly usable without further "manual" setting of environment variables.

The implementation requires the start of a login shell for the environment to be sourced on startup.

Extended documentation to reflect the use of the feature.

metal3-io-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign iurygregory for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/ironic-client/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 10 months ago

/cc @zaneb @dtantsur @elfosardo

tuminoid commented 10 months ago

/retest

tuminoid commented 10 months ago

Please rebase, we've recently added some linters for this repo and made fixes to the README.md that are conflicting with your additions. Sorry for the inconvenience.

tuminoid commented 8 months ago

Please squash your commits. You have fixup commit pending.

@dtantsur please take a another look if this is OK now.

metal3-io-bot commented 3 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

metal3-io-bot commented 2 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 1 month ago

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

metal3-io-bot commented 1 month ago

@metal3-io-bot: Closed this PR.

In response to [this](https://github.com/metal3-io/ironic-client/pull/16#issuecomment-2439169280): >Stale issues close after 30d of inactivity. Reopen the issue with `/reopen`. Mark the issue as fresh with `/remove-lifecycle stale`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.