search

metal3-io / ironic-client

Ironic Client Utilities (for debugging via Ironic APIs)
Apache License 2.0
3 stars 10 forks source link

install ironic client with pip to fix build #21

Closed NymanRobin closed 6 months ago

NymanRobin commented 6 months ago

With the sunset of the tripleo-repos project, the docker build started failing. It appears that using pip is now the preferred method for installing the ironic-client for Python instead of using RPM packages. To fix the docker build, switch the build to use pip for installation.

This fixes: #19

After the build is fixed we can try to keep it healthy in the future with #20

NymanRobin commented 6 months ago

Maybe @Rozzii or @dtantsur can verify if this is the correct way to go about fixing the build?

Rozzii commented 6 months ago

/lgtm

metal3-io-bot commented 6 months ago

@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/ironic-client/pull/21#issuecomment-2117008025): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
NymanRobin commented 6 months ago

/cc @dtantsur @elfosardo Any chance you can have a look?

elfosardo commented 6 months ago

/approve

metal3-io-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-client/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 6 months ago

@tuminoid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/ironic-client/pull/21#pullrequestreview-2081277134): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
NymanRobin commented 6 months ago

Thanks for the review @dtantsur! I have now updated the PR :)

derekhiggins commented 6 months ago

/lgtm