metal3-io / ironic-client

Ironic Client Utilities (for debugging via Ironic APIs)
Apache License 2.0
3 stars 10 forks source link

Add Slack notification for image build workflow failure #23

Closed NymanRobin closed 5 months ago

NymanRobin commented 6 months ago

Adds Slack notification for EST internal teams slack channel for image build workflow failures. This is so a wider audience can more quickly detect failures and avoid scenarios such as #19 where the build was broken for months before anyone noticed.

Also fixed the indent in the file to be consistent with the other repositories in metal3 org

Sadly, this is currently only EST internal hopefully if this works out well we can find a solution were all interested can partake

Fixes: #20

metal3-io-bot commented 6 months ago

@tuminoid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/ironic-client/pull/23#pullrequestreview-2084469462): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
NymanRobin commented 5 months ago

/cc @dtantsur @elfosardo Could you please have a look at this? It helps us quite a lot in detecting errors quickly

elfosardo commented 5 months ago

/approve

metal3-io-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-client/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dtantsur commented 5 months ago

/lgtm