search

metal3-io / ironic-client

Ironic Client Utilities (for debugging via Ironic APIs)
Apache License 2.0
3 stars 10 forks source link

shellcheck only files #24

Closed tuminoid closed 6 months ago

tuminoid commented 6 months ago

Make shellcheck consider only files.

If branch name ended with .sh or .sh/something, it was found on the filesystem as something ending with .sh, and shellcheck picked it up, and linting failed obviously.

elfosardo commented 6 months ago

/approve

metal3-io-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-client/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 6 months ago

/cc @dtantsur @zaneb

dtantsur commented 6 months ago

/lgtm