search

metal3-io / ironic-client

Ironic Client Utilities (for debugging via Ironic APIs)
Apache License 2.0
3 stars 10 forks source link

🐛CloudInit: baremetal node fails to deploy using a local config drive #28

Closed blallau closed 2 months ago

blallau commented 2 months ago

Trying to deploy using a config drive on the client side requires 'genisoimage' binary to be present. This patch install the missing package.

Fixes #27

metal3-io-bot commented 2 months ago

Hi @blallau. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 months ago

/ok-to-test

tuminoid commented 2 months ago

/test ?

metal3-io-bot commented 2 months ago

@tuminoid: The following commands are available to trigger required jobs:

In response to [this](https://github.com/metal3-io/ironic-client/pull/28#issuecomment-2356037435): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 months ago

/cc @dtantsur @elfosardo

elfosardo commented 2 months ago

/approve

metal3-io-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-client/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
blallau commented 2 months ago

/cc @tuminoid

tuminoid commented 2 months ago

/cc @tuminoid

Sorry, I don't have LGTM powers in this repo, you need one of the guys I requested to review to LGTM.

derekhiggins commented 2 months ago

/lgtm