search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 117 forks source link

Remove ServerName from httpd.conf #442

Closed elfosardo closed 12 months ago

elfosardo commented 1 year ago

The ServerName value is not mandatory and it's not really needed as apache can get that from /etc/hosts. Also this configuration will never work in an ipv6 environemnt as ipv6 ips are not allowed as values for ServerName.

elfosardo commented 1 year ago

/test-ubuntu-integration-main

elfosardo commented 1 year ago

/test-centos-integration-main

elfosardo commented 1 year ago

looks like CI issue still ongoing

elfosardo commented 1 year ago

/test-ubuntu-integration-main

elfosardo commented 1 year ago

/test-centos-integration-main

elfosardo commented 12 months ago

\o/

derekhiggins commented 12 months ago

/lgtm

dtantsur commented 12 months ago

/approve

metal3-io-bot commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment