search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 117 forks source link

Detect default images downloaded by ipa-downloader #452

Closed dtantsur closed 11 months ago

dtantsur commented 11 months ago

In the future, this will simplify BMO configuration by no longer requiring deploy kernel/ramdisk to be provided via environment variables.

dtantsur commented 11 months ago

/test-ubuntu-integration-main

tuminoid commented 11 months ago

Since the filesystem sharing is different on centos, let's run this as well. LGTM in general.

/test-centos-integration-main

tuminoid commented 11 months ago

Btw, should we make the test-centos-integration-main required test for ironic-image, like it is in BMO etc? @kashifest @dtantsur @elfosardo

dtantsur commented 11 months ago

@tuminoid if there is an actual difference - yes, definitely

/test-ubuntu-integration-main /test-centos-integration-main

elfosardo commented 11 months ago

Btw, should we make the test-centos-integration-main required test for ironic-image, like it is in BMO etc? @kashifest @dtantsur @elfosardo

yes, we should

kashifest commented 11 months ago

Btw, should we make the test-centos-integration-main required test for ironic-image, like it is in BMO etc? @kashifest @dtantsur @elfosardo

yes, we should

Done

dtantsur commented 11 months ago

/test-ubuntu-integration-main

elfosardo commented 11 months ago

/approve

metal3-io-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment