search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 117 forks source link

Don't install ironic-lib from git when it's not requested #454

Closed dtantsur closed 11 months ago

dtantsur commented 11 months ago

When IRONIC_LIB_SOURCE is not set, we should use pip. Otherwise, we can a conflict with upper-constraints.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

dtantsur commented 11 months ago

/test-ubuntu-integration-main /test-centos-integration-main

elfosardo commented 11 months ago

/approve

metal3-io-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, iurygregory, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo,iurygregory] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dtantsur commented 11 months ago

I suspect nothing will pass until we get https://review.opendev.org/c/openstack/ironic-python-agent/+/902231 in...