metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 117 forks source link

add condition for ipxe_tls template usage #463

Closed Rozzii closed 10 months ago

Rozzii commented 10 months ago

Previously custom ironic ipxe template was taken into use in ironic config even when the TLS support was not enabled for the ironic-image.

This commit:

Rozzii commented 10 months ago

/cc @lentzi90 @dtantsur @elfosardo

Rozzii commented 10 months ago

/test-centos-integration-main /test-ubuntu-integration-main

elfosardo commented 10 months ago

/approve

metal3-io-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Rozzii commented 10 months ago

/test-centos-integration-main /test-ubuntu-integration-main

Rozzii commented 10 months ago

/test-centos-integration-main

Rozzii commented 10 months ago

/override test-ubuntu-integration-main ubuntu test was expected to fail because of the CI issue that this PR might be able to fix but not until it is merged.

metal3-io-bot commented 10 months ago

@Rozzii: Overrode contexts on behalf of Rozzii: test-ubuntu-integration-main

In response to [this](https://github.com/metal3-io/ironic-image/pull/463#issuecomment-1860142227): >/override test-ubuntu-integration-main >ubuntu test was expected to fail because of the CI issue that this PR might be able to fix but not until it is merged. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.