search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 117 forks source link

:book: add OpenSSF Scorecard badge to README #465

Closed tuminoid closed 9 months ago

tuminoid commented 10 months ago

Add OpenSSF Scorecard badge to README. It is checked by the CLOmonitor and lowers our score by not having it. We have worked to improve the scores, so we can display the score as well.

tuminoid commented 10 months ago

Scorecard is not generated for ironic-image by openssf for some reason, but it is also a code-lite repo in CLO, so it is NOT monitored for this repo.

/hold until I've checked why the scoring is not done for this.

tuminoid commented 10 months ago

Adding ironic-image to the OpenSSF Scorecard project list, so it can display this badge: https://github.com/ossf/scorecard/pull/3783

tuminoid commented 9 months ago

Adding ironic-image to the OpenSSF Scorecard project list, so it can display this badge: ossf/scorecard#3783

Merged. The badge will be available sometime next week as the run cycle is one week and it is unknown which weekday will do our repos.

tuminoid commented 9 months ago

/unhold The scorecard badge is now valid as project is included in securityscorecard.dev scans.

tuminoid commented 9 months ago

/override test-centos-integration-main test-ubuntu-integration-main Its readme change.

metal3-io-bot commented 9 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main, test-ubuntu-integration-main

In response to [this](https://github.com/metal3-io/ironic-image/pull/465#issuecomment-1903348511): >/override test-centos-integration-main test-ubuntu-integration-main >Its readme change. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 9 months ago

/cc @Rozzii @lentzi90 /assign @elfosardo @dtantsur

tuminoid commented 9 months ago

/retitle :book: add OpenSSF Scorecard badge to README

metal3-io-bot commented 9 months ago

@kashifest: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/ironic-image/pull/465#pullrequestreview-1835887098): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elfosardo commented 9 months ago

/approve

metal3-io-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment