metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 117 forks source link

🌱 reduce github actions permissions #471

Closed tuminoid closed 8 months ago

tuminoid commented 8 months ago

Cleanup GH actions, and move permissions from top-level to job-level. Restrict job running to the main repository.

This restores token permission score to 10/10.

/hold until https://github.com/metal3-io/ip-address-manager/pull/408 is reviewed and merged as this is replication of that.

tuminoid commented 8 months ago

Holding until dependabot in IPAM with new permissions has been tested. It should have some PRs next Monday at latest.

tuminoid commented 8 months ago

/hold Waiting for https://github.com/metal3-io/ironic-image/pull/456 to merge first.

elfosardo commented 8 months ago

/test-centos-integration-main /test-ubuntu-integration-main

elfosardo commented 8 months ago

/approve

metal3-io-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 8 months ago

/unhold Dependency was merged.

tuminoid commented 8 months ago

/override test-centos-integration-main test-ubuntu-integration-main GH actions change, not relevant.

metal3-io-bot commented 8 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main, test-ubuntu-integration-main

In response to [this](https://github.com/metal3-io/ironic-image/pull/471#issuecomment-1891834741): >/override test-centos-integration-main test-ubuntu-integration-main >GH actions change, not relevant. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 8 months ago

/cc @lentzi90 @Rozzii