search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 117 forks source link

:bug: Ironic inspector iPXE address doesn't include brackets for IPv6 addresses #472

Closed hroyrh closed 8 months ago

hroyrh commented 8 months ago

What this PR does / why we need it: The Ironic inspector iPXE config, the kernel and ramdisk use IRONIC_IP which doesn't put brackets around IPv6 addresses. This causes the Host address to be malformed when iPXE sends a request.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

elfosardo commented 8 months ago

/test-centos-integration-main /test-ubuntu-integration-main

elfosardo commented 8 months ago

/approve

metal3-io-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dtantsur commented 8 months ago

/test-ubuntu-integration-main

hroyrh commented 8 months ago

/test-ubuntu-integration-main

dtantsur commented 8 months ago

/lgtm