search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 117 forks source link

🌱 Use bookworm slim to build sushy-tools image #473

Closed elfosardo closed 10 months ago

elfosardo commented 10 months ago

It should reduce the final size of the image from 1.2GB to 500MB

elfosardo commented 10 months ago

/test-centos-integration-main /test-ubuntu-integration-main

elfosardo commented 10 months ago

if it works :D CI doesn't seem very happy

elfosardo commented 10 months ago

/test-centos-integration-main /test-ubuntu-integration-main

elfosardo commented 10 months ago

/hold

elfosardo commented 10 months ago

/unhold

elfosardo commented 10 months ago

removing gcc at the end saves us even more bringing the image down to 350 MB

elfosardo commented 10 months ago

/test-centos-integration-main /test-ubuntu-integration-main

tuminoid commented 10 months ago

/test-centos-integration-main /test-ubuntu-integration-main

tuminoid commented 10 months ago

removing gcc at the end saves us even more bringing the image down to 350 MB

342MB on my machine, even better. No need to leave compiler laying around indeed.

edit: I need to learn to read.

tuminoid commented 10 months ago

/test-ubuntu-integration-main

CI networking has been real bad today.

dtantsur commented 10 months ago

/approve

elfosardo commented 10 months ago

/test-centos-integration-main /test-ubuntu-integration-main

elfosardo commented 10 months ago

/test-centos-integration-main /test-ubuntu-integration-main

metal3-io-bot commented 10 months ago

@kashifest: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/ironic-image/pull/473#pullrequestreview-1813843396): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment