search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 117 forks source link

🌱 Rename IRONIC_INSPECTOR_VLAN_INTERFACES #478

Closed dtantsur closed 8 months ago

dtantsur commented 8 months ago

This value is not specific to inspection, let alone its ironic-inspector implementation. Rename to IRONIC_ENABLE_VLAN_INTERFACES. The old name is still supported but deprecated.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

dtantsur commented 8 months ago

/test-centos-integration-main /test-ubuntu-integration-main

elfosardo commented 8 months ago

/approve

metal3-io-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hroyrh commented 8 months ago

/lgtm

metal3-io-bot commented 8 months ago

@hroyrh: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/ironic-image/pull/478#issuecomment-1968958974): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elfosardo commented 8 months ago

/lgtm