search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 117 forks source link

🌱 bump shellcheck to v0.10.0 #484

Closed tuminoid closed 6 months ago

tuminoid commented 6 months ago

Shellcheck had its first release since 2022, so bump it.

/hold needs project-infra change too.

tuminoid commented 6 months ago

/unhold Project-infra has gone in. /test shellcheck

/override test-centos-integration-main test-ubuntu-integration-main

metal3-io-bot commented 6 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main, test-ubuntu-integration-main

In response to [this](https://github.com/metal3-io/ironic-image/pull/484#issuecomment-1985661500): >/unhold >Project-infra has gone in. >/test shellcheck > >/override test-centos-integration-main test-ubuntu-integration-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elfosardo commented 6 months ago

/approve

metal3-io-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment