search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 117 forks source link

🌱 add ARG BASE_IMAGE to sushy-tools Dockerfile #491

Closed tuminoid closed 5 months ago

tuminoid commented 5 months ago

To be consistent with other Dockerfiles, and to allow easy replacement of the base image, add ARG BASE_IMAGE to sushy-tools Dockerfile.

tuminoid commented 5 months ago

/test-centos-integration-main
/test-ubuntu-integration-main

elfosardo commented 5 months ago

/approve

metal3-io-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 5 months ago

/test-ubuntu-integration-main

Unrelated flake.

tuminoid commented 5 months ago

/cc @lentzi90