search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 117 forks source link

✨ Provide scripts to be used as liveness/readiness probes #492

Closed dtantsur closed 5 months ago

dtantsur commented 5 months ago

This change is the first step towards https://github.com/metal3-io/baremetal-operator/issues/1528. Through these scripts, we can decouple the validation logic from the pod definition and provide more sophisticated tests in the future.

Right now, the same curl command is used (modulo supporting all variants of deploying Ironic).

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

dtantsur commented 5 months ago

/cc @tuminoid /hold

I need to find a way to test these, they're not currently wired in.

tuminoid commented 5 months ago

Or locally, by pointing dev-env to local repos via BMOPATH and IRONIC_IMAGE_PATH and setting BUILD_BMO_LOCALLY=true and BUILD_IRONIC_IMAGE_LOCALLY=true. Also set FORCE_REPO_UPDATE=false.

I'm running this test now locally.

dtantsur commented 5 months ago

/test-centos-integration-main

dtantsur commented 5 months ago

/test-ubuntu-integration-main

tuminoid commented 5 months ago

/test-ubuntu-integration-main

dtantsur commented 5 months ago

/hold cancel

derekhiggins commented 5 months ago

/lgtm

iurygregory commented 5 months ago

/approve

metal3-io-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [iurygregory] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 5 months ago

/cherry-pick release-24.1

metal3-io-bot commented 5 months ago

@tuminoid: new pull request created: #493

In response to [this](https://github.com/metal3-io/ironic-image/pull/492#issuecomment-2045343620): >/cherry-pick release-24.1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.