search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 117 forks source link

⚠️ Use unix sockets by default for reverse proxy communication #494

Closed dtantsur closed 5 months ago

dtantsur commented 5 months ago

Using additional ports increase the chance of conflicting with something else on the node and is also potentially less efficient. We have used Unix sockets via a shared directory in OpenShift for a while without any complaints. I think upstream should do the same.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

dtantsur commented 5 months ago

/test-centos-integration-main /test-ubuntu-integration-main

dtantsur commented 5 months ago

/test-centos-integration-main /test-ubuntu-integration-main

elfosardo commented 5 months ago

/approve

metal3-io-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 5 months ago

/lgtm

tuminoid commented 5 months ago

/cherry-pick release-24.1

metal3-io-bot commented 5 months ago

@tuminoid: new pull request created: #495

In response to [this](https://github.com/metal3-io/ironic-image/pull/494#issuecomment-2046509774): >/cherry-pick release-24.1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.