search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 117 forks source link

⚠️ Use unix sockets by default for reverse proxy communication #495

Closed metal3-io-bot closed 6 months ago

metal3-io-bot commented 7 months ago

This is an automated cherry-pick of #494

/assign tuminoid

tuminoid commented 7 months ago

/rettile ⚠️ Use unix sockets by default for reverse proxy communication

tuminoid commented 7 months ago

/hold Jenkins triggers not active for this branch, fixing.

Also needs https://github.com/metal3-io/ironic-image/pull/493 to merge first.

tuminoid commented 7 months ago

/retitle ⚠️ Use unix sockets by default for reverse proxy communication

tuminoid commented 7 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

Running with the new keywords, and checking if they actually run the right tests. After that, will change the required tests configs.

kashifest commented 6 months ago

/test-centos-integration-main

kashifest commented 6 months ago

/test-centos-integration-main

tuminoid commented 6 months ago

/retest

tuminoid commented 6 months ago

Just checking what Prow now shows for this branch:

/test ?

metal3-io-bot commented 6 months ago

@tuminoid: The following commands are available to trigger required jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/ironic-image/pull/495#issuecomment-2051060026): >Just checking what Prow now shows for this branch: > >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elfosardo commented 6 months ago

/approve @tuminoid I think we can unhold this now

metal3-io-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/release-24.1/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 6 months ago

Yes, I was just waiting if I need to rebase this on top of the other or if the CI handles testing that properly. /unhold