search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 116 forks source link

WIP: 🌱 remove world-writable socket #501

Closed tuminoid closed 4 months ago

tuminoid commented 4 months ago

We don't need a world-writable socket anymore. Group write is enough as we have users created in configure-nonroot.sh to share GIDs, and on top, Inspector is now removed.

metal3-io-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 4 months ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 4 months ago

@tuminoid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main cd3d744d226c228a5a882ae48a4385e12711ed79 link true /test metal3-ubuntu-e2e-integration-test-main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
metal3-io-bot commented 4 months ago

@tuminoid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main cd3d744d226c228a5a882ae48a4385e12711ed79 link true /test metal3-ubuntu-e2e-integration-test-main
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tuminoid commented 4 months ago

Since Centos passed and Ubuntu didn't, I guess we have issues still with the Ironic sockets in local Ironic installation, as mounts are different than in Centos/K8s installation.

/close

metal3-io-bot commented 4 months ago

@tuminoid: Closed this PR.

In response to [this](https://github.com/metal3-io/ironic-image/pull/501#issuecomment-2079199829): >Since Centos passed and Ubuntu didn't, I guess we have issues still with the Ironic sockets in local Ironic installation, as mounts are different than in Centos/K8s installation. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.