search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 116 forks source link

🐛 Disable unused network interfaces #504

Closed dtantsur closed 3 months ago

dtantsur commented 4 months ago

Loading the "flat" network interfaces causes a confusing warnings about unset cleaning_network parameter. Just disable it.

Sort the options in the configuration.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

dtantsur commented 4 months ago

/ok-to-test

dtantsur commented 4 months ago

/retitle 🐛 Disable unused network interfaces

dtantsur commented 4 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

tuminoid commented 4 months ago

/ok-to-test

Btw we bumped prow today, this workaround is not needed anymore.

iurygregory commented 4 months ago

/approve

metal3-io-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [iurygregory] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 3 months ago

/cc @lentzi90 @Rozzii Seems fine to me, PTAL