search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 116 forks source link

🌱 Read Ironic htpasswd from file or environment variable #506

Closed MahnoorAsghar closed 3 months ago

MahnoorAsghar commented 4 months ago

This PR reverts #482 and #498, because it is not secure to mount the ironic username and password as plain text files into ironic-image. The PR adds the ability to mount the ironic htpasswd as a file (to introduce a better way than just using environment variable for this purpose).

MahnoorAsghar commented 4 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

Rozzii commented 4 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

Rozzii commented 4 months ago

I was not following this "username:password" topic for some time but I have also found interesting when I have noticed that the username and the password is in plain text so I agree with this PR, thanks! /lgtm

Rozzii commented 4 months ago

Need an approver /cc @elfosardo

tuminoid commented 4 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

MahnoorAsghar commented 4 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

MahnoorAsghar commented 4 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

MahnoorAsghar commented 4 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

tuminoid commented 4 months ago

/retest CI should be better now.

Rozzii commented 4 months ago

/test metal3-centos-e2e-integration-test-main

Rozzii commented 3 months ago

/test metal3-centos-e2e-integration-test-main

MahnoorAsghar commented 3 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

MahnoorAsghar commented 3 months ago

/test metal3-centos-e2e-integration-test-main

elfosardo commented 3 months ago

/approve

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Rozzii commented 3 months ago

/lgtm