✨ Allow independent credentials for JSON RPC

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³

Apache License 2.0

56 stars 116 forks source link

✨ Allow independent credentials for JSON RPC #518

Open dtantsur opened 3 months ago

dtantsur commented 3 months ago

It's probably not a great idea to allow users to easily access JSON RPC, so a different set of credentials is useful.

Also allow the secret to be mounted directly without the convoluted auth-config format (which is an ini file in reality). Deprecate the auth-config approach (JSON RPC is the last instance where it's used).

metal3-io-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from dtantsur. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dtantsur commented 2 months ago

/test metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 3 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.